Skip to content

Conversation

@thejpster
Copy link
Contributor

Makes sure that we're generating FPU code correctly. Prints a nice ASCII art sine wave to standard out, using f32 and f64.

Makes sure that we're generating FPU code correctly. Prints a nice
ASCII art sine wave to standard out, using f32 and f64.
Copy link
Contributor

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found a nit, should libm be optional as with gic, or should gic no longer be optional for the examples?

@thejpster
Copy link
Contributor Author

ping @robamu for a +1 please

@robamu
Copy link
Contributor

robamu commented Oct 25, 2025

Just 2 nitpicks, looks good to me otherwise :)

@jonathanpallant
Copy link
Contributor

Just 2 nitpicks, looks good to me otherwise :)

Good catch! I defined a constant and forgot to use it :/

@jonathanpallant jonathanpallant added this pull request to the merge queue Oct 25, 2025
Merged via the queue into rust-embedded:main with commit fec3e63 Oct 25, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants